Conversation
There was a problem hiding this comment.
We need to call into the else branch below to write the correct head.
There was a problem hiding this comment.
Yes, I was mixed about what was the best and conclude the least we touch things the best it is.
Here either:
- we let the head where it is, knowing that the list has been cut in two, with second part having a wrong head.
- move the head to next values potentially cutting a large part of the list.
There was a problem hiding this comment.
But this means we will print out this message over and over again. (Given there is no modifcation in between)
There was a problem hiding this comment.
I don't think this code should attempt to fix stuff, but ok maybe we can do it.
Then we should also maybe:
- remove entry when in storage::get decode has failing,
- set the next to None when enumeration is broken,
There was a problem hiding this comment.
oh ya ok at least we can make previous being None for the next element. indeed
|
Any update? |
|
actually I'm confused about what to do:
Is that correct ? I still kind of prefer not touching anything if possible but if you agree on this then I make it. |
|
looks strictly better than before, which is enough for a merge. |
2c7b473 to
f5304de
Compare
|
Resolved |
Fix corrupted storage panic
In the long term we should implement #3700